SDK-124 JWT mechanism not engaged via InAppManager #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #968 +/- ##
===========================================
- Coverage 85.19% 69.38% -15.82%
===========================================
Files 91 109 +18
Lines 6301 8916 +2615
===========================================
+ Hits 5368 6186 +818
- Misses 933 2730 +1797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaodordio
force-pushed
the
fix/SDK-124-JWT-mechanism-not-engaged-via-InAppManager
branch
from
1d1cda9 to
427d15a
Compare
joaodordio
force-pushed
the
fix/SDK-124-JWT-mechanism-not-engaged-via-InAppManager
branch
from
941ba65 to
7c07b7a
Compare
Contributor
|
LGTM! and great work! Clean solution and m glad we added some tests too :) |
sumeruchat
approved these changes
Nov 11, 2025
joaodordio
deleted the
fix/SDK-124-JWT-mechanism-not-engaged-via-InAppManager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
On
InAppHelpergetInAppMessagesFromServerfunc we were calling theapiClient.getInAppMessages(NSNumber(value: number))directly.This meant that any JWT 401 errors were not being handled with refresh retries, like they are for example when routed through
RequestProcessorUtil.That's the main change, everything else is just boiler plate changes to support injecting the AuthManager that's required by the
RequestProcessorUtil